-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deps: bump rustc-ap to v691 #1143
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, I'll fix these tests later.
Should we block releasing 2.1.41 on fixed tests? |
@Xanewok |
@calebcartwright this was probably caused by not having rust-src component - that's what I'm seeing locally after introducing the # rust-toolchain
[toolchain]
channel = "nightly-2020-11-27"
components = ["rust-src"] After installing this locally, now only |
Running the test with
There's a good chance that rust-lang/rust#78461 broke the test - it seems that inline attribute on a generic parameter is not recognized, i.e. |
Thanks! |
We have another broken toolstate issue with RLS and rustfmt that requires bumping the rustc-ap crates to the latest version.
I am getting one test failure in my local environment even after these changes, but I was getting five test failures with the latest on master so I'm guessing this is unrelated
Refs rust-lang/rust#79406 and rust-lang/rust#79407
r? @kngwyu and/or @Xanewok