Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: bump rustc-ap to v691 #1143

Merged
merged 1 commit into from
Nov 29, 2020
Merged

Conversation

calebcartwright
Copy link
Contributor

We have another broken toolstate issue with RLS and rustfmt that requires bumping the rustc-ap crates to the latest version.

I am getting one test failure in my local environment even after these changes, but I was getting five test failures with the latest on master so I'm guessing this is unrelated

Refs rust-lang/rust#79406 and rust-lang/rust#79407

r? @kngwyu and/or @Xanewok

Copy link
Collaborator

@kngwyu kngwyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll fix these tests later.

@kngwyu kngwyu merged commit ca3ba9c into racer-rust:master Nov 29, 2020
@Xanewok
Copy link
Collaborator

Xanewok commented Nov 30, 2020

Should we block releasing 2.1.41 on fixed tests?

@kngwyu
Copy link
Collaborator

kngwyu commented Nov 30, 2020

@Xanewok
This failure is because the stdlib location changed and can be critical.
I'll do my best but please wait for 1~2 days (now my work time for OSS is limited, sorry).

@Xanewok
Copy link
Collaborator

Xanewok commented Nov 30, 2020

I am getting one test failure in my local environment even after these changes, but I was getting five test failures with the latest on master so I'm guessing this is unrelated

@calebcartwright this was probably caused by not having rust-src component - that's what I'm seeing locally after introducing the rust-toolchain file. One fix would be to use the new format (introduced in Rustup 1.23), i.e.:

# rust-toolchain
[toolchain]
channel = "nightly-2020-11-27"
components = ["rust-src"]

After installing this locally, now only completes_for_alias_with_resolved_generics, which is the same error that is failing in the CI.

@Xanewok
Copy link
Collaborator

Xanewok commented Nov 30, 2020

Running the test with RUST_LOG=trace (and calling env_logger::try_init()) yields a following log:

[2020-11-30T19:47:32Z DEBUG racer::ast] destructure_pattern_to_ty point BytePos(4) ty Match(Match ["Vec", "/home/xanewok/.rustup/toolchains/nightly-2020-11-27-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library/alloc/src/vec.rs", BytePos(10934), true, Struct(GenericsArgs([])), |pub struct Vec<T, #[unstable(feature = " ", issue = " ")] A: AllocRef = Global>|]) pat: Ident(ByValue(Not), v#0, None)

There's a good chance that rust-lang/rust#78461 broke the test - it seems that inline attribute on a generic parameter is not recognized, i.e. Struct(GenericsArgs([])). I'll dig deeper.

@Xanewok
Copy link
Collaborator

Xanewok commented Dec 4, 2020

FYI I published a 2.1.41 version that includes this dep bump.

cc @kngwyu

@kngwyu
Copy link
Collaborator

kngwyu commented Dec 5, 2020

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants