Fixed bug with replacing language after uploading transcript #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4y4ts
reviewed
Jan 13, 2017
| @@ -226,22 +226,29 @@ function StudioEditableXBlock(runtime, element) { | |||
| }) | |||
| }; | |||
|
|
|||
| var pushTranscript = function (lang, label, url){ | |||
| var pushTranscript = function (lang, label, url, oldLang, $uploadButton){ | |||
z4y4ts
approved these changes
Jan 16, 2017
sendr
force-pushed
the
bugfix/replace_transciprt_lang
branch
from
d71d352 to
88151e7
Compare
z4y4ts
added a commit
that referenced
this pull request
Jan 18, 2017
* dev: Add pylint integration with TravisCI and pylintrc config Fix indentation in player-context-menu.js, use dot notation when possible Minor JavaScript optimization in studio_edit.js Fixed bug with replacing existing language after uploading transcript (#70) Downloading transcripts with correct filename (#68) fix "get_transcript_download_link" function (#67) Make transcripts download link follow selected transcript language (#64) Remove unused styles (#66) Add display captions Fix typo in install_requires section in setup.py Wrap transcripts in route_transcript() for on-the-fly convertion Fix pycaption dependency specification in requirements.txt Reduce code duplication and add docstrings Add support for .srt transcripts Enable popup submenu in Edge Fixed Speed label for Brightcove # Conflicts: # .travis.yml # pylintrc # requirements.txt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/VCpilMW8/122-upload-transcripts-subtitle-should-not-be-removed-when-we-change-language