Refactor of including javascript content to brightcove player #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4y4ts
suggested changes
Jan 4, 2017
| var controlsTabOrder = [ | ||
| 'progressControl', | ||
| 'playToggle', | ||
| 'playbackRateMenuButton', | ||
| 'volumeMenuButton', | ||
| 'resolutionSwitcher', | ||
| // 'resolutionSwitcher', |
| 'captionsButton': controlBar.captionsButton.el_, | ||
| 'volumeMenuButton': controlBar.volumeMenuButton.volumeBar.el_, | ||
| 'fullscreenToggle': controlBar.fullscreenToggle.el_, | ||
| // 'resolutionSwitcher': _player.controlBar.resolutionSwitcher, |
| 'volumeMenuButton': controlBar.volumeMenuButton.volumeBar.el_, | ||
| 'fullscreenToggle': controlBar.fullscreenToggle.el_, | ||
| // 'resolutionSwitcher': _player.controlBar.resolutionSwitcher, | ||
| 'playbackRateMenuButton': controlBar.playbackRateMenuButton.el_ | ||
| }; | ||
|
|
||
| // Swith off tabIndex for volumeMenuButton and free slot for volumeBar |
| @@ -396,3 +396,42 @@ body .video-js .vjs-menu-button-popup .vjs-menu .vjs-menu-item:hover { | |||
| background-color: #171a1b; | |||
| color: #0ea6ec; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Extract this new code to .../css/transcripts.css.
polesye
reviewed
Jan 4, 2017
|
|
||
| def add_js_content(self, path, **context): | ||
| """ | ||
| Helper for adding javascript content to brightcove player |
There was a problem hiding this comment.
Is it only for brightcove or can be used in other players?
There was a problem hiding this comment.
Right now we need this for Brightcove only. But it can be used for other players too.
There was a problem hiding this comment.
In this case, it makes sense to avoid using brightcove player name in the docstring
sendr
force-pushed
the
brightcove_player_refactor
branch
from
5a0f1e3 to
c87c596
Compare
z4y4ts
approved these changes
Jan 4, 2017
dyudyunov
pushed a commit
that referenced
this pull request
Jan 13, 2022
Bump django from 2.2.24 to 2.2.25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.