Refactor contextmenu creation #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@polesye please take a look. You've had some concerns regarding context menu implementation IIRC. |
polesye
suggested changes
Dec 27, 2016
| @@ -16,82 +19,93 @@ domReady(function() { | |||
| // VideoJS Player() object necessary for context menu creation | |||
| var player = videojs('{{ video_player_id }}'); | |||
|
|
|||
| /** | |||
| * Create elements of nested context submenu. | |||
| */ | |||
| function createNestedContextSubMenu(e) { | |||
| var target = e.target; | |||
|
|
|||
| if (target.matches("li.vjs-menu-item") | |||
| && target.innerText == player.contextmenuUI.content[3].label | |||
| liSubMenu.onclick = function() { | ||
| player.playbackRate(parseFloat(playbackRate)); | ||
| } | ||
| })(); |
There was a problem hiding this comment.
it's better to use DocumentFragment in bulk DOM element generations.
forEach method can also help you to simply the code.
There was a problem hiding this comment.
Add context menu Add context menu Created context menu with videojs-contextmenu-ui plugin Created a nested menu for a context menu Fix nested submenu creation sequence Prevented nested submenu duplicates Set an event handler to a context menu item to create a nested submenu Enable custom context menu for each backend separately Minor changes as per convention Refactor context menu Refactor with pure JavaScript Refactor hiding a nested submenu Refactor contextmenu creation Refactored menu labels update Changed playback rate assignment Moved hide/show of submenu to css Optimized submenu creation
OPersian
force-pushed
the
feature/context-menu
branch
from
b078f48 to
31218fc
Compare
z4y4ts
added a commit
that referenced
this pull request
Jan 6, 2017
…linter * commit '324aa43674d214d184637bf3ec52331495fe12da': Enable popup submenu in Edge Fixed Speed label for Brightcove Remove unused static assets Disable .srt uploads for transcripts as this format not supported by VideoJS Add language select Not include videojs-transcripts.js to page if no transcripts (#50) Refactor of including javascript content to brightcove player Add caption for video Enabling/disabling of interactive transcripts Optimized submenu creation (#41) Add download transcript button for students Buttons for videojs player Replace videojs playback rate control with custom Refactor context menu Feature/player id validation (#37) Save state on next button clicking (#39) Add text "Speed" on large viewports Refactor context menu
dyudyunov
pushed a commit
that referenced
this pull request
Jan 13, 2022
…unity-fixes 1.0.0 community alpha ... merge (broken) community fork changes toward Py3 / Juniper compat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored menu labels update
Changed playback rate assignment
Moved hide/show of submenu to css