Feature/context menu #33
Conversation
| .vjs-contextmenu-ui-submenu .vjs-submenu-item:hover { | ||
| background-color: rgba(0, 0, 0, 0.5); | ||
| text-shadow: 0em 0em 1em white; | ||
| } |
| var player = videojs('{{ video_player_id }}'); | ||
|
|
||
| // Delegate creation of a nested submenu for a context menu | ||
| $(videoPlayer).on('mouseenter', 'li.vjs-menu-item:last', function(e) { |
There was a problem hiding this comment.
Why don't you use player.on() event binding function?
Event name may be different, but I don't see reason we need jQuery here.
See code samples here http://blog.videojs.com/Hiding-and-Showing-Video-Player-Controls/
There was a problem hiding this comment.
Event delegation seems not to work correctly if an event is bound to a videojs object. Would prefer to re-write with pure JavaScript in the next PR.
There was a problem hiding this comment.
Ok, then please do so.
I approve this PR for the sake of demo, but please continue with refactoring this before switch to another task.
| @@ -0,0 +1,90 @@ | |||
| /** | |||
There was a problem hiding this comment.
I know our js file names are a bit messy, but we need to stick to something. Let it be dashes rather than underscores.
So can you please rename it to player-context-menu.js
Add context menu Created context menu with videojs-contextmenu-ui plugin Created a nested menu for a context menu Fix nested submenu creation sequence Prevented nested submenu duplicates Set an event handler to a context menu item to create a nested submenu Enable custom context menu for each backend separately Minor changes as per convention
OPersian
force-pushed
the
feature/context-menu
branch
from
3393b33 to
212f34a
Compare
Add Vanta required PR and Issue templates
No description provided.