Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make transcripts indexable for LMS search #294

Merged
merged 2 commits into from
Jan 23, 2018

Conversation

wowkalucky
Copy link
Collaborator

Added

  • index_dictionary xblock method which makes xblock indexable for search;
  • simple vtt_to_txt xblock method to extract transcripts content for indexing;

@wowkalucky wowkalucky self-assigned this Jan 23, 2018
@codecov
Copy link

codecov bot commented Jan 23, 2018

Codecov Report

Merging #294 into dev will decrease coverage by <.01%.
The diff coverage is 5.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #294      +/-   ##
==========================================
- Coverage   86.14%   86.14%   -0.01%     
==========================================
  Files          42       42              
  Lines        2758     2793      +35     
  Branches       26       26              
==========================================
+ Hits         2376     2406      +30     
- Misses        379      384       +5     
  Partials        3        3
Flag Coverage Δ
#acceptance 89.03% <5.71%> (-1.18%) ⬇️
#unit 84.46% <5.71%> (+0.01%) ⬆️
Impacted Files Coverage Δ
video_xblock/mixins.py 86.42% <14.28%> (-2.36%) ⬇️
video_xblock/video_xblock.py 63.96% <3.57%> (-6.04%) ⬇️
...static/js/studio-edit/transcripts-manual-upload.js 36.36% <0%> (+9.09%) ⬆️
.../spec/studio-edit/transcript-manual-upload-spec.js 100% <0%> (+9.75%) ⬆️
video_xblock/static/js/studio-edit/utils.js 92.85% <0%> (+21.42%) ⬆️
...eo_xblock/static/js/spec/studio-edit/utils-spec.js 94.11% <0%> (+35.29%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65433a8...8aa8c00. Read the comment docs.

@wowkalucky wowkalucky merged commit cf21f8a into dev Jan 23, 2018
@wowkalucky wowkalucky deleted the add_transcripts_to_search_index branch January 23, 2018 11:15
wowkalucky added a commit that referenced this pull request Jan 24, 2018
* Make transcripts indexable for LMS search

* Fix javascript unit tests
wowkalucky added a commit that referenced this pull request Jan 24, 2018
* Bump __version__ to 0.9.4

* Make transcripts indexable for LMS search (#294)

* Fix javascript unit tests

* Fixed `fullscreen` button overlapping (#295)

* Fix for issue #292: languages selected differ between transcript and caption buttons (#296)

* Update xblock dependecies due to Ginkgo release

* Remove from captions/transcripts control's menu active language highlighting

* Prepare CHANGELOG.md for a new release

* Bump __version__ to 0.10.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant