Interactive transcripts display #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
z4y4ts
reviewed
Dec 14, 2016
| "xblockEventPlugin": {} | ||
| } | ||
| }) | ||
|
|
||
| frag = super(YoutubePlayer, self).get_frag(**context) | ||
| print(context) |
| "dynamicLabel": True, | ||
| "default": "low" | ||
| }, | ||
| # "videoJsResolutionSwitcher": { |
There was a problem hiding this comment.
Delete completely, add a note when to revert back or don't touch it.
| @@ -5,4 +5,9 @@ | |||
| width="829" height="511" | |||
| data-setup='{{ data_setup }}' | |||
| > | |||
| {% for caption in player_state.transcripts %} | |||
There was a problem hiding this comment.
Why single element of transcripts is caption?
Here and in similar places
There was a problem hiding this comment.
i will rename to var caption to transcript
|
Also, please update |
z4y4ts
approved these changes
Dec 15, 2016
get transcripts for youtube, wistia, brightcove - add transcripts to context template players - add button for subtitles and text block with translates
dorosh
force-pushed
the
feature/transcrip_display
branch
from
6baf678 to
8c64b03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get transcripts for youtube, wistia, brightcove