Feature/bugfix offset #26
Conversation
| videojs.plugin('xblockEventPlugin', xblockEventPlugin); | ||
| videojs('{{ video_player_id }}').xblockEventPlugin(); | ||
| player.xblockEventPlugin(); | ||
| videojs.plugin('offset', vjsoffset); |
There was a problem hiding this comment.
I don't see where vjsoffset is defined?
There was a problem hiding this comment.
vjsoffset is defined here
https://github.com/raccoongang/videojs-offset/blob/master/dist/videojs-offset.js#L88
I met problem with player visible in
https://github.com/raccoongang/videojs-offset/blob/master/dist/videojs-offset.js#L89
for brightcove. That's why I call plugin inside html file
There was a problem hiding this comment.
Ok, now I see. Please change to more explicit window.vjsoffset.
| @@ -14,13 +15,14 @@ | |||
| from xblock.fragment import Fragment | |||
| from xblock.validation import ValidationMessage | |||
| from xblockutils.studio_editable import StudioEditableXBlockMixin | |||
| from xmodule.fields import RelativeTime | |||
| from django.utils.translation import ugettext | |||
There was a problem hiding this comment.
Use XBlock's ugettext instead
https://github.com/edx/XBlock/blob/master/xblock/core.py#L204
There was a problem hiding this comment.
Met the problem
We're having trouble rendering your component
Students will not be able to access this component. Re-edit your component to fix the error.
Error: unbound method ugettext() must be called with XBlock instance as first argument (got str instance instead)
Change to _("...")
| player.offset({ | ||
| "start": {{ start_time }}, | ||
| "end": {{ end_time }} | ||
| }); |
| @@ -5,6 +5,7 @@ | |||
| """ | |||
|
|
|||
| import logging | |||
| import datetime | |||
There was a problem hiding this comment.
Please reorder imports according to code style
https://edx.readthedocs.io/projects/edx-developer-guide/en/latest/style_guides/python_guidelines.html#imports-order
|
Resolve conflicts, squash and commit! |
xahgmah
force-pushed
the
feature/bugfix_offset
branch
3 times, most recently
from
ff91bae to
329942b
Compare
Add new library videojs-offset Add new fields start_time and end_time
xahgmah
force-pushed
the
feature/bugfix_offset
branch
from
329942b to
2e05e70
Compare
No description provided.