Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download and upload handout file on MongoDB #20

Merged
merged 1 commit into from
Dec 7, 2016

Conversation

sendr
Copy link

@sendr sendr commented Dec 7, 2016

No description provided.

default='',
scope=Scope.content,
display_name='Upload handout',
help='You can upload handout file for students'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add i18n

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@@ -209,3 +245,19 @@ def get_player(self):
"""
player = BaseVideoPlayer.load_class(self.player_name)
return player()

def _make_field_info(self, field_name, field):
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add docstring

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@polesye
Copy link

polesye commented Dec 7, 2016

@xahgmah or @dorosh please also review.
@z4y4ts just FYI

@polesye
Copy link

polesye commented Dec 7, 2016

don't forget to squash before merge

@sendr sendr force-pushed the feature/handout_upload_mongo_storage branch from fba92ec to b47497e Compare December 7, 2016 16:41
@sendr sendr merged commit e6429a7 into dev Dec 7, 2016
@sendr sendr deleted the feature/handout_upload_mongo_storage branch February 24, 2017 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants