Bug/relocate django vars #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add into options "tabindex" to togleButton - add into options "tabIndex" to transcript
dorosh
force-pushed
the
bug/relocate-django-vars
branch
2 times, most recently
from
c9e3f8b to
864a035
Compare
z4y4ts
suggested changes
Feb 13, 2017
| }; // eslint-disable-line | ||
|
|
||
| var transcripts = {}; | ||
| player_state_obj.transcripts.forEach(function loop_transcript(transcript) { |
video_xblock/backends/base.py
Outdated
| @@ -105,10 +106,24 @@ def metadata_fields(self): | |||
| """ | |||
| return [] | |||
|
|
|||
| def _extra_context(self, context): | |||
There was a problem hiding this comment.
Why new function and new context['player_state_json']?
video_xblock/backends/base.py
Outdated
| @@ -5,6 +5,7 @@ | |||
| Base Video player plugin | |||
| """ | |||
|
|
|||
| import json | |||
dorosh
force-pushed
the
bug/relocate-django-vars
branch
from
864a035 to
18f939f
Compare
-add valid json into player context on backend -parse json on frontend and use js object as global var
dorosh
force-pushed
the
bug/relocate-django-vars
branch
from
18f939f to
7adf6b5
Compare
z4y4ts
approved these changes
Feb 13, 2017
OPersian
pushed a commit
that referenced
this pull request
Feb 14, 2017
* Move django vars from js -add valid json into player context on backend -parse json on frontend and use js object as global var
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.