forked from openedx/frontend-lib-special-exams
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add following proctoring exam pages: user verification, software download, ready to start instruction #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ngs and instructions
idegtiarov
requested changes
May 25, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, tests are failed, could you please fix them so we can go further in the review process.
ihor-romaniuk
approved these changes
May 25, 2021
…ding on the frontend
00a853f
to
63d12ef
Compare
63d12ef
to
809b88d
Compare
idegtiarov
approved these changes
May 26, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
UvgenGen
approved these changes
May 26, 2021
ihor-romaniuk
added a commit
that referenced
this pull request
Jun 1, 2021
…e download, ready to start instruction (#17) * feat: add user verification page * feat: add proctored exam instructions page (when exam is in 'ready_to_start' status) * feat: get provider software download url from backend instead of building on the frontend * fix: merge errors * fix: fix tests * feat: add verification url to user verification page Co-authored-by: Ihor Romaniuk <[email protected]> Co-authored-by: Sagirov Eugeniy <[email protected]>
viktorrusakov
added a commit
that referenced
this pull request
Jun 14, 2021
…ng / practice exams (#17) * feat: check for verification only for proctored exams (previously were checkin for practice and onboarding also) * feat: add Error, Submitted and Verified instruction pages * test: add tests for Error, Submitted and Verified instructions * feat: add allowProctoringOptOut to examState and use getSequenceMetadata API * feat: Use sequence from the learning app instead of hitting the endpoint Co-authored-by: Viktor Rusakov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added user verification, software download, ready to start instructions pages for proctoring exam flow.
OeX_Proctoring-149
OeX_Proctoring-154
OeX_Proctoring-208