Use NOTION_RELEASE environment value if defined as version and sh compat #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raboof
reviewed
May 3, 2019
|
You're right, I'm swallowing the version it should go to the else condition too. |
|
The 'else' expects you to be in a directory that follows the github tag zip download naming conventions - if there is a .git directory present then it's unlikely the directory name follows that convention... |
knixeur
force-pushed
the
fix_version_no_git
branch
from
5590e6f
to
9484376
Compare
knixeur
changed the title
raboof
reviewed
May 3, 2019
| if [ -e ".git" ]; then | ||
| # Git: | ||
| echo -n `git describe` | ||
| if [[ -n $(git status -s) ]]; then | ||
| if [ ! -z "$(echo -n `git status -s`)" ]; then |
knixeur
force-pushed
the
fix_version_no_git
branch
from
9484376
to
0a265ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use technique suggested in https://stackoverflow.com/q/7292584to check git can be executed
Edit: I've updated the PR, we talked in IRC and an environment value is a better fit