Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup: quiet '-Wextra-semi-stmt' clang warning #198

Merged
merged 1 commit into from
Oct 7, 2019
Merged

Cleanup: quiet '-Wextra-semi-stmt' clang warning #198

merged 1 commit into from
Oct 7, 2019

Conversation

ideasman42
Copy link
Collaborator

Ensures macros end with a semi-colon,
avoids accidents with macro use.

raboof
raboof reviewed Oct 5, 2019
View reviewed changes
ioncore/event.c Outdated Show resolved Hide resolved
@ideasman42
Cleanup: quiet '-Wextra-semi-stmt' clang warning
dff670d 
Ensures macros end with a semi-colon,
avoids accidents with macro use.
raboof
raboof approved these changes Oct 7, 2019
View reviewed changes
Copy link
Owner

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd be in favour of removing even more ((void)0) and ;, but this is already a nice improvement 👍

@raboof raboof merged commit 196bb91 into master Oct 7, 2019
@raboof raboof deleted the cleanup-warn-extra-semi-pr branch October 7, 2019 07:57
@raboof raboof added the development issues that don't impact end users directly label Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
development issues that don't impact end users directly
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ideasman42 @raboof