Global safe tempdir #167
Merged
Global safe tempdir #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wilhelmy
force-pushed
the
global-safe-tempdir
branch
from
75392ae
to
a14e86d
Compare
|
Travis bugged out on me, but I guess this is good to go. |
|
Error on Travis seem related to some temporary problem with their apt cache, lgtm |
raboof
approved these changes
Aug 7, 2019
| /* | ||
| * notion/ioncore/tempdir.c | ||
| * | ||
| * Copyright (c) 2019 Moritz Wilhelmy |
There was a problem hiding this comment.
I kinda prefer Copyright (c) 2019 the Notion team, but this is fine I guess.
|
|
||
| if(strlen(listenfile)>SOCK_MAX){ | ||
| warn("Too long socket path"); | ||
| if(strlen(listenfile)>sizeof(addr.sun_path)-1){ |
|
indeed a travis rebuild did the trick |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a safe temporary directory created using mkdtemp(3), makes it accessible to Lua, uses it to put the mod_notionflux socket inside and deletes everything on exit.