Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read and write history from/to a file #160

Merged
merged 1 commit into from
Jul 31, 2019
Merged

read and write history from/to a file #160

merged 1 commit into from
Jul 31, 2019

Conversation

wilhelmy
Copy link
Collaborator

@wilhelmy wilhelmy commented Jul 30, 2019 •
edited by raboof
Loading

fixes #158

@raboof raboof changed the title notionflux: read and write history from/to a file (fixes #158) read and write history from/to a file Jul 31, 2019
@raboof raboof added the notionflux run-time Lua interface label Jul 31, 2019
raboof
raboof approved these changes Jul 31, 2019
View reviewed changes
mod_notionflux/notionflux/notionflux.c
}

char fname[4096];
snprintf(fname, sizeof(fname), "%s/.notion/notionflux.hist", home);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not fully .history?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always found long file extensions weird, but if that's your only gripe feel free to change it :)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@raboof raboof merged commit 21cb26b into master Jul 31, 2019
@raboof raboof deleted the notionflux-histfile branch July 31, 2019 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raboof raboof raboof approved these changes

Assignees
No one assigned
Labels
notionflux run-time Lua interface
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save history
2 participants
@wilhelmy @raboof