No mod_dock minimum height

[raboof]

We're enabling mod_dock by default for Notion 4.

By default, mod_dock takes up space even when there is nothing inside it. It would be nice if we could avoid that.

[wilhelmy]

Does it though? I thought that was a configuration mistake on my part?

[knixeur]

iirc it does when there was something temporarily on it. I'm using polybar right now, and if I kill it dock still takes the space used for it.

Edit:

https://github.com/raboof/notion/blob/master/mod_dock/dock.c#L782

When you kill something, n_dockapps is now 0 and defaults to tile_size. I guess if n_dockapps is 0, width and height should be 0?

Edit2:
https://github.com/raboof/notion/blob/master/mod_dock/dock.c#L340
dock_get_tile_size sets it by default to dock_param_tile_width which in
https://github.com/raboof/notion/blob/master/mod_dock/dock.c#L292
sets it to 64

[raboof]

Does it though? I thought that was a configuration mistake on my part?

Actually you're mentioning exactly this issue in that thread, #149 (comment) ;)

[raboof]

(the defaults put it at the bottom-left rather than the top-left, which is a bit less bad, but still :) )

[raboof]

https://github.com/raboof/notion/blob/master/mod_dock/dock.c#L782
When you kill something, n_dockapps is now 0 and defaults to tile_size. I guess if n_dockapps is 0, width and height should be 0?

Makes sense to me, though it seems this was intentionally changed in 6098344 it doesn't clarify why ;)