Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional useful capabilities #234

Merged
merged 1 commit into from
Jul 11, 2022
Merged

Additional useful capabilities #234

merged 1 commit into from
Jul 11, 2022

Conversation

qouoq
Copy link
Contributor

@qouoq qouoq commented Jul 9, 2022

Following #233, here's an update for main.cpp (error message and comment), and the man page.

A first important point is that the error message was not shown on the console. The unexpected behavior was introduced with #231 as far as I can tell. I have no experience of ncurses, but my feeling is that initializing it (calling init_ui) before outputting to stderr/stdout messes up the console output. My tentative solution is to defer initialization to just before main loop (lines 301-304 in this PR), which in my tests works well for error and normal cases. (Before #231, behavior was also messy, in the sense that newlines were not displayed properly in the console.)

The second point is that the long setcap command line in the man page looks quite ugly. I quickly tried to look at groff macros, but that looks like a lot of complicated stuff, so trying to find an elegant way to display that is not something I can help much with I'm afraid..

Specify additional capabilities in main.cpp (error message and comment),
and in man page.
Copy link
Owner

@raboof raboof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I won't merge since you still have it marked as 'Draft'

@qouoq
Copy link
Contributor Author

qouoq commented Jul 10, 2022

Alrighty, I couldn't find a more elegant way to handle this long line in the man page.

@qouoq qouoq marked this pull request as ready for review July 10, 2022 17:00
@raboof raboof merged commit 9360468 into raboof:main Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants