Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log an error if an exception occurs during logging of diffs #64

Merged
merged 0 commits into from
Jun 13, 2023
Merged

Log an error if an exception occurs during logging of diffs #64

merged 0 commits into from
Jun 13, 2023

Conversation

martinvisser
Copy link
Contributor

Fixes #63

@martinvisser martinvisser linked an issue Jun 8, 2023 that may be closed by this pull request
No error logged if an exception occurs during the logging of differences #63
Closed
@martinvisser martinvisser force-pushed the 63-no-error-logged-if-an-exception-occurs-during-the-logging-of-differences branch from 2d7545c to 2e9bd21 Compare June 8, 2023 13:56
stevenschenk
stevenschenk previously approved these changes Jun 13, 2023
View reviewed changes
@martinvisser martinvisser force-pushed the 63-no-error-logged-if-an-exception-occurs-during-the-logging-of-differences branch from 2e9bd21 to 6f6dfe1 Compare June 13, 2023 07:08
GuusdeWit
GuusdeWit previously approved these changes Jun 13, 2023
View reviewed changes
@martinvisser martinvisser force-pushed the 63-no-error-logged-if-an-exception-occurs-during-the-logging-of-differences branch from 6f6dfe1 to 65bb42e Compare June 13, 2023 07:13
@martinvisser martinvisser requested a review from a team June 13, 2023 07:13
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@martinvisser martinvisser merged this pull request into main Jun 13, 2023
@martinvisser martinvisser deleted the 63-no-error-logged-if-an-exception-occurs-during-the-logging-of-differences branch June 13, 2023 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuusdeWit GuusdeWit GuusdeWit approved these changes

@stevenschenk stevenschenk stevenschenk left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

No error logged if an exception occurs during the logging of differences
3 participants
@martinvisser @stevenschenk @GuusdeWit