Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'start_ssl_listener/4' has wrong parameter order #3180

Merged
merged 1 commit into from
Jul 9, 2021
Merged

'start_ssl_listener/4' has wrong parameter order #3180

merged 1 commit into from
Jul 9, 2021

Conversation

tomyouyou
Copy link
Contributor

The 'ConcurrentConnsSupsCount' should be the last paramter.

The 'ConcurrentConnsSupsCount' should be the last paramter
Copy link
Contributor

@lhoguin lhoguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on reading of the code. Will QA. Thanks!

Copy link
Contributor

@lhoguin lhoguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA good. Thanks!

@lhoguin lhoguin merged commit 27c5482 into rabbitmq:master Jul 9, 2021
@lhoguin
Copy link
Contributor

lhoguin commented Jul 9, 2021

This will need to be backported to both v3.9.x and v3.8.x.

michaelklishin pushed a commit that referenced this pull request Jul 9, 2021
…_order

'start_ssl_listener/4' has wrong parameter order

NumAcceptors and NumConnsSup were swapped out for TLS connections.

(cherry picked from commit 27c5482)
michaelklishin pushed a commit that referenced this pull request Jul 9, 2021
…_order

'start_ssl_listener/4' has wrong parameter order

NumAcceptors and NumConnsSup were swapped out for TLS connections.

(cherry picked from commit 27c5482)
@michaelklishin
Copy link
Member

Backported to v3.8.x.

@michaelklishin
Copy link
Member

Backported to v3.9.x.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants