Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of global prefetch #12454

Closed
wants to merge 1 commit into from

Conversation

johanrhodin
Copy link
Contributor

Proposed Changes

RabbitMQ 4.0 removes Global prefetch (https://www.rabbitmq.com/blog/2021/08/21/4.0-deprecation-announcements#removal-of-global-qos). This is a step to remove mentions of global prefetch in the in-product docs.

Types of Changes

  • Bug fix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause an observable behavior change in existing systems)
  • Documentation improvements (corrections, new content, etc)
  • Cosmetic change (whitespace, formatting, etc)
  • Build system and/or CI

Checklist

Further Comments

https://www.rabbitmq.com/docs/consumer-prefetch would need more in-depth changes.

@michaelklishin
Copy link
Member

This removes the mention in one place but leaves

  • A channel metric
  • A Prometheus gauge
  • At least one other management UI
  • A rabbitmqctl list_channels info item (field)

michaelklishin added a commit that referenced this pull request Oct 5, 2024
michaelklishin added a commit that referenced this pull request Oct 5, 2024
As suggested by @johanrhodin in #12454.

This keeps the Prometheus plugin part but
marks it as deprecated. We can remove it in
4.1.
mergify bot pushed a commit that referenced this pull request Oct 5, 2024
As suggested by @johanrhodin in #12454.

This keeps the Prometheus plugin part but
marks it as deprecated. We can remove it in
4.1.

(cherry picked from commit 80f4797)
michaelklishin added a commit that referenced this pull request Oct 7, 2024
As suggested by @johanrhodin in #12454.

This keeps the Prometheus plugin part but
marks it as deprecated. We can remove it in
4.1.
LoisSotoLopez pushed a commit to cloudamqp/rabbitmq-server that referenced this pull request Oct 21, 2024
As suggested by @johanrhodin in rabbitmq#12454.

This keeps the Prometheus plugin part but
marks it as deprecated. We can remove it in
4.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants