Skip to content
This repository has been archived by the owner on Nov 17, 2020. It is now read-only.

Document new health check endpoints #858

Merged
merged 4 commits into from
Oct 19, 2020
Merged

Document new health check endpoints #858

merged 4 commits into from
Oct 19, 2020

Conversation

dcorbacho
Copy link
Contributor

@dcorbacho dcorbacho commented Oct 16, 2020 •
edited by michaelklishin
Loading

These health checks were introduced in #854 (#844).

Types of Changes

  • Bugfix (non-breaking change which fixes issue #NNNN)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance)

Checklist

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin
Simpler wording for new health check endpoint docs
d17ae68
@michaelklishin
Further updates to health check endpoint docs
3c66a09 
 * Remove documentation to the now deprecated One True Health Check™.
   It is too intrusive and too prone to false positives to recommend.
 * Aliveness test is also a health check, and will respond with a 200
   or 503 as of #856
@michaelklishin
Clarify
ad40eeb
@michaelklishin michaelklishin merged commit 30ad96f into master Oct 19, 2020
michaelklishin added a commit that referenced this pull request Oct 19, 2020
@michaelklishin
Merge pull request #858 from rabbitmq/document-health-checks
cd91b09 
Document new health check endpoints

(cherry picked from commit 30ad96f)
@michaelklishin michaelklishin deleted the document-health-checks branch October 19, 2020 05:25
@michaelklishin michaelklishin modified the milestone: 3.8.10 Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@michaelklishin michaelklishin michaelklishin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dcorbacho @michaelklishin