Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7.x: remove deprecated message publishing method overloads #895

Merged
merged 1 commit into from
Jul 7, 2020
Merged

7.x: remove deprecated message publishing method overloads #895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions projects/RabbitMQ.Client/client/api/IBasicPublishBatch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ namespace RabbitMQ.Client
{
public interface IBasicPublishBatch
{
[Obsolete("Use Add(string exchange, string routingKey, bool mandatory, IBasicProperties properties, ReadOnlyMemory<byte> body) instead. Will be replaced in version 7.0", false)]
void Add(string exchange, string routingKey, bool mandatory, IBasicProperties properties, byte[] body);
void Add(string exchange, string routingKey, bool mandatory, IBasicProperties properties, ReadOnlyMemory<byte> body);
void Publish();
}
}
6 changes: 0 additions & 6 deletions projects/RabbitMQ.Client/client/impl/BasicPublishBatch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,12 +62,6 @@ internal BasicPublishBatch (ModelBase model, int sizeHint)
_commands = new List<Command>(sizeHint);
}

public void Add(string exchange, string routingKey, bool mandatory, IBasicProperties basicProperties, byte[] body)
{
ReadOnlyMemory<byte> bodyAsMemory = body;
Add(exchange, routingKey, mandatory, basicProperties, bodyAsMemory);
}

public void Add(string exchange, string routingKey, bool mandatory, IBasicProperties basicProperties, ReadOnlyMemory<byte> body)
{
var method = new BasicPublish
Expand Down
61 changes: 0 additions & 61 deletions projects/RabbitMQ.Client/client/impl/BasicPublishBatchExtensions.cs
View file
Open in desktop

This file was deleted.

8 changes: 1 addition & 7 deletions projects/Unit/APIApproval.Approve.verified.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,10 +56,6 @@ namespace RabbitMQ.Client
public bool Redelivered { get; }
public string RoutingKey { get; }
}
public static class BasicPublishBatchExtensions
{
public static void Add(this RabbitMQ.Client.IBasicPublishBatch batch, string exchange, string routingKey, bool mandatory, RabbitMQ.Client.IBasicProperties properties, System.ReadOnlyMemory<byte> body) { }
}
public class BinaryTableValue
{
public BinaryTableValue() { }
Expand Down Expand Up @@ -295,9 +291,7 @@ namespace RabbitMQ.Client
}
public interface IBasicPublishBatch
{
[System.Obsolete("Use Add(string exchange, string routingKey, bool mandatory, IBasicProperties prop" +
"erties, ReadOnlyMemory<byte> body) instead. Will be replaced in version 7.0", false)]
void Add(string exchange, string routingKey, bool mandatory, RabbitMQ.Client.IBasicProperties properties, byte[] body);
void Add(string exchange, string routingKey, bool mandatory, RabbitMQ.Client.IBasicProperties properties, System.ReadOnlyMemory<byte> body);
void Publish();
}
public interface IConnection : RabbitMQ.Client.INetworkConnection, System.IDisposable
Expand Down