Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AutorecoveringConnection uses ContinuationTimeout from ConnectionFactory #823

Conversation

AndrzejKrol
Copy link
Contributor

@AndrzejKrol AndrzejKrol commented May 4, 2020

Proposed Changes

This is to address issue #821. ContinuationTimeout set on Connection Factory was ignored if AutomaticRecoveryEnabled was set to true. Exact same behavior is already implemented for non-auto recovery connection:

model.ContinuationTimeout = m_factory.ContinuationTimeout;

Types of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask on the
mailing list. We're here to help! This is simply a reminder of what we are
going to look for before merging your code.

  • I have read the CONTRIBUTING.md document
  • I have signed the CA (see https://cla.pivotal.io/sign/rabbitmq)
  • All tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in related repositories

@michaelklishin michaelklishin merged commit c9e36dc into rabbitmq:master May 4, 2020
@michaelklishin
Copy link
Member

Thank you!

michaelklishin added a commit that referenced this pull request May 4, 2020
…_ConnectionFactory

AutorecoveringConnection uses ContinuationTimeout from ConnectionFactory

(cherry picked from commit c9e36dc)
@michaelklishin
Copy link
Member

Backported to 6.x.

@HelioVaGator
Copy link

Thanks a lot, guys 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants