Leverage System.Threading.RateLimiting
#1706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lukebakken so do you like this approach? |
|
Yeah this is great! |
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1682-rate-limiting
branch
from
f15355a to
e02734d
Compare
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1682-rate-limiting
branch
from
ec61e45 to
35f2757
Compare
lukebakken
changed the title
System.Threading.RateLimiting
* Cosmetic formatting * Use `RateLimitLease` instead of `IDisposable` in internal classes. * Move `ThrottlingRateLimiter` to `RabbitMQ.Client` namespace. * Add the outline of a test for throttling publishes based on outstanding confirms. * Do not error exit on Windows when `inet_error` is found in logs * Modify `TestPublisherConfirmationThrottling` to use toxiproxy.
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1682-rate-limiting
branch
from
35f2757 to
f8a18cd
Compare
|
@danielmarbach - anything to add? Everything looks good to me. |
Not really. The only thing that crossed my mind was adding the publish sequence number as Metadata to the rate limiter but that is something that can be done when needed in enhancements |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #1704
Thanks for the code @danielmarbach