Fix flaky connection recovery tests. #1148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukebakken
force-pushed
the
rabbitmq-dotnet-client-1140
branch
from
3d00716 to
38bd629
Compare
There was a problem hiding this comment.
I can reproduce this failure reliably on two machines:
Starting test execution, please wait...
A total of 1 test files matched the specified pattern.
[xUnit.net 00:00:07.57] RabbitMQ.Client.Unit.TestConnectionRecovery.TestPublishRpcRightAfterReconnect [FAIL]
Failed RabbitMQ.Client.Unit.TestConnectionRecovery.TestPublishRpcRightAfterReconnect [3 s]
Error Message:
Assert.NotEqual() Failure
Expected: Not 406
Actual: 406
Stack Trace:
at RabbitMQ.Client.Unit.TestConnectionRecovery.TestPublishRpcRightAfterReconnect() in /path/to/dotnet_client.git/projects/Unit/TestConnectionRecovery.cs:line 880
|
Yep, fix one test, break another. Of course that test works fine on my machine. |
|
@michaelklishin give it another run when you have time. |
michaelklishin
approved these changes
Feb 22, 2022
|
Thanks. I'll back-port. |
|
Looks good to me. Good catch! |
lukebakken
pushed a commit
that referenced
this pull request
Feb 23, 2022
Fix flaky connection recovery tests. (cherry picked from commit 2d04378)
lukebakken
added a commit
that referenced
this pull request
Feb 23, 2022
Merge pull request #1148 from rabbitmq/rabbitmq-dotnet-client-1140
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1140 by assigning the new Model to _innerChannel at the correct place. This prevents a race condition during consumer recovery.
cc @michaelklishin @bollhals