Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge pull request #1141 from rabbitmq/lukebakken/fix-appveyor #1143

Merged
merged 1 commit into from
Feb 14, 2022

Conversation

lukebakken
Copy link
Contributor

Fix and update AppVeyor build

(cherry picked from commit 4628927)

@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1141-main branch from 1e14b78 to 1e1e2b8 Compare February 9, 2022 16:17
@lukebakken lukebakken marked this pull request as ready for review February 9, 2022 16:54
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1141-main branch from 1e1e2b8 to cc9c0d3 Compare February 9, 2022 20:21
@michaelklishin
Copy link
Member

@lukebakken given that ci/appveyor/pr fails, should I merge or wait some more?

@lukebakken lukebakken marked this pull request as draft February 11, 2022 16:40
@lukebakken
Copy link
Contributor Author

Thanks for waiting. I marked this ready when everything was green but another build revelealed yet another flaky test. I'm going to look into it.

Fix and update AppVeyor build

(cherry picked from commit 4628927)

Lower count of expected acks

Hopefully fixes flaky tests
@lukebakken lukebakken force-pushed the rabbitmq-dotnet-client-1141-main branch from 10a94f0 to 2f5a810 Compare February 12, 2022 16:36
@lukebakken lukebakken marked this pull request as ready for review February 12, 2022 18:40
@lukebakken
Copy link
Contributor Author

@michaelklishin all set if you'd like to review. I will then port these changes to the 7.x branch.

@michaelklishin michaelklishin merged commit 389819a into main Feb 14, 2022
@michaelklishin michaelklishin deleted the rabbitmq-dotnet-client-1141-main branch February 14, 2022 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants