ModelBase.WaitForConfirmsOrDieAsync uses ShutdownInitiator.Application rather than Library

[StevenBonePgh]

I am using logic similar to that mentioned in #159 to recover connections, and it has worked great except for a recent case. The logic is:

model.ModelShutdown += (sender, args) =>
{
    if (args.Initiator == ShutdownInitiator.Application)
        return; //We closed it, do not attempt to recover.
    // Library/Peer closed it so recover. [Code snipped]
}; 

However, the code in ModelBase.WaitForConfirmsOrDieAsync does this:

rabbitmq-dotnet-client/projects/RabbitMQ.Client/client/impl/ModelBase.cs

Lines 1098 to 1121 in 66dc8ca

	public async Task WaitForConfirmsOrDieAsync(CancellationToken token = default)
	{
	try
	{
	bool onlyAcksReceived = await WaitForConfirmsAsync(token).ConfigureAwait(false);
	if (onlyAcksReceived)
	{
	return;
	}
	await CloseAsync(
	new ShutdownEventArgs(ShutdownInitiator.Application, Constants.ReplySuccess, "Nacks Received",
	new IOException("nack received")),
	false).ConfigureAwait(false);
	}
	catch (TaskCanceledException exception)
	{
	await CloseAsync(new ShutdownEventArgs(ShutdownInitiator.Application,
	Constants.ReplySuccess,
	"Timed out waiting for acks",
	exception),
	false).ConfigureAwait(false);
	}
	}

Since it is using ShutdownInitiator.Application, my autorecovery code does not fire. I would expect the RabbitMq Client to use ShutdownInitiator.Library in this case. Is this a bug, or should I handle things differently?

[michaelklishin]

I doubt this was an intentional decision. Please submit a PR.