Refactor other use of ConcurrentDictionary GetOrAdd

rabbitmq · May 20, 2020 · ac4ad8b · ac4ad8b
1 parent 75ac0db
commit ac4ad8b
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 11 deletions.
diff --git a/projects/RabbitMQ.Client/client/impl/AsyncConsumerWorkService.cs b/projects/RabbitMQ.Client/client/impl/AsyncConsumerWorkService.cs
@@ -8,14 +8,8 @@ namespace RabbitMQ.Client.Impl
 {
     internal sealed class AsyncConsumerWorkService : ConsumerWorkService
     {
-        private readonly ConcurrentDictionary<IModel, WorkPool> _workPools;
-        private readonly Func<IModel, WorkPool> _startNewWorkPoolFunc;
-
-        public AsyncConsumerWorkService()
-        {
-            _workPools = new ConcurrentDictionary<IModel, WorkPool>();
-            _startNewWorkPoolFunc = model => StartNewWorkPool(model);
-        }
+        private readonly ConcurrentDictionary<IModel, WorkPool> _workPools = new ConcurrentDictionary<IModel, WorkPool>();
+        private readonly Func<IModel, WorkPool> _startNewWorkPoolFunc = model => StartNewWorkPool(model);
 
         public void Schedule<TWork>(ModelBase model, TWork work) where TWork : Work
         {
@@ -25,10 +19,14 @@ public void Schedule<TWork>(ModelBase model, TWork work) where TWork : Work
              *
              * The lock is necessary because calling the value delegate is not atomic.
              */
+            WorkPool workPool;
+
             lock (_workPools)
             {
-                _workPools.GetOrAdd(model, _startNewWorkPoolFunc).Enqueue(work);
+                workPool = _workPools.GetOrAdd(model, _startNewWorkPoolFunc);
             }
+
+            workPool.Enqueue(work);
         }
 
         private static WorkPool StartNewWorkPool(IModel model)

diff --git a/projects/RabbitMQ.Client/client/impl/ConsumerWorkService.cs b/projects/RabbitMQ.Client/client/impl/ConsumerWorkService.cs
@@ -8,13 +8,21 @@ namespace RabbitMQ.Client.Impl
     class ConsumerWorkService
     {
         private readonly ConcurrentDictionary<IModel, WorkPool> _workPools = new ConcurrentDictionary<IModel, WorkPool>();
+        private readonly Func<IModel, WorkPool> _startNewWorkPoolFunc = model => StartNewWorkPool(model);
 
         public void AddWork(IModel model, Action fn)
         {
-            _workPools.GetOrAdd(model, StartNewWorkPool).Enqueue(fn);
+            WorkPool workPool;
+
+            lock (_workPools)
+            {
+                workPool = _workPools.GetOrAdd(model, _startNewWorkPoolFunc);
+            }
+
+            workPool.Enqueue(fn);
         }
 
-        private WorkPool StartNewWorkPool(IModel model)
+        private static WorkPool StartNewWorkPool(IModel model)
         {
             var newWorkPool = new WorkPool();
             newWorkPool.Start();