* Making HandleChannleClose async

rabbitmq · Feb 19, 2024 · 48ee0d0 · 48ee0d0
1 parent c8ce6d8
commit 48ee0d0
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 5 deletions.
diff --git a/projects/RabbitMQ.Client/client/framing/Channel.cs b/projects/RabbitMQ.Client/client/framing/Channel.cs
@@ -48,9 +48,10 @@ public override Task ConnectionTuneOkAsync(ushort channelMax, uint frameMax, ush
             return ModelSendAsync(method, cancellationToken).AsTask();
         }
 
-        public override void _Private_ChannelCloseOk()
+        public override Task _Private_ChannelCloseOkAsync(CancellationToken cancellationToken)
         {
-            ChannelSend(new ChannelCloseOk());
+            var method = new ChannelCloseOk();
+            return ModelSendAsync(method, cancellationToken).AsTask();
         }
 
         public override void _Private_ChannelFlowOk(bool active)

diff --git a/projects/RabbitMQ.Client/client/impl/ChannelBase.cs b/projects/RabbitMQ.Client/client/impl/ChannelBase.cs
@@ -769,7 +769,8 @@ protected void HandleChannelClose(in IncomingCommand cmd)
 
                 Session.Close(CloseReason, false);
 
-                _Private_ChannelCloseOk();
+                // TODO async
+                _Private_ChannelCloseOkAsync(CancellationToken.None).EnsureCompleted();
             }
             finally
             {
@@ -952,8 +953,7 @@ protected bool HandleQueueDeclareOk(in IncomingCommand cmd)
             }
         }
 
-        // TODO async
-        public abstract void _Private_ChannelCloseOk();
+        public abstract Task _Private_ChannelCloseOkAsync(CancellationToken cancellationToken);
 
         // TODO async
         public abstract void _Private_ChannelFlowOk(bool active);