Fix case where empty HTTP response caused panic in reconcile loop #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunyiLyu
reviewed
Apr 7, 2021
ChunyiLyu
reviewed
Apr 7, 2021
ChunyiLyu
approved these changes
Apr 7, 2021
ChunyiLyu
reviewed
Apr 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #88
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
Both
validateResponseandvalidateResponseForDeletioncan panic if they are asked to validate a nil-reponse object. Rabbithole returns this in some cases, where there is a Go error or a 401 from the API.For both of these, the function now returns an error if both
errand the response is nil.Additional Context
This also adds in integration testing for one of the controllers, and the infrastructure to allow this to be done on the other controllers in the future.