Disallow updates of Queue arguments #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielePalaia
approved these changes
May 28, 2024
Queue arguments can't be updated in RabbitMQ. The webhook now disallows updates on queue arguments, matching the behaviour of RabbitMQ. Signed-off-by: Aitor Perez Cedres <[email protected]>
There is little value in running vuln in unit-tests. When it complains, it complains about CVEs in your local Go version, which is not the same Go binary that will build in CI (we use stable and oldstable). The target `git-commit-sha` was a no-op. The logic to determine whether to add a `-` at the end of the commit SHA was broken, it was always chosing to add a `-`. Now the `GIT_COMMIT` is always the HEAD commit SHA + `-dev` suffix. Signed-off-by: Aitor Perez Cedres <[email protected]>
Zerpet
force-pushed
the
fix/inmutable-queue-args
branch
from
6d89906 to
f13f359
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #822
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
Queue arguments can't be updated in RabbitMQ. The webhook now disallows updates on queue arguments, matching the behaviour of RabbitMQ.