feat: Allow policy to apply to specific queue types (classic/quorum) & streams #668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of RabbitMQ v3.12.0, policies can be defined to only apply to specific queue types. This commit allows setting those types on the applyTo field of a Policy.
|
@nickstamat, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@nickstamat, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@nickstamat, VMware has approved your signed contributor license agreement. |
|
Thanks for the contribution! We noticed that |
nickstamat
changed the title
|
@MirahImage Added |
MirahImage
approved these changes
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #667.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
This PR adds
classic_queues,quorum_queues,streamsto the list of supported values for theApplyTofield ofPolicy.Additional Context
As far as I could see, no other changes are required for this functionality. This is just going through a kubernetes-side validation, and the
michaelklishin/rabbit-holeclient simply accepts any string for theApplyTofield. Please correct me if I'm wrong, I'm not familiar with the entire codebase.