621 allow for plain http connections #622
Conversation
|
@JorgeAndresQuintero, you must sign our contributor license agreement before your changes are merged. Click here to sign the agreement. If you are a VMware employee, read this for further instruction. |
|
@JorgeAndresQuintero, we have received your signed contributor license agreement. The review is usually completed within a week, but may take longer under certain circumstances. Another comment will be added to the pull request to notify you when the merge can proceed. |
|
@JorgeAndresQuintero, VMware has approved your signed contributor license agreement. |
There was a problem hiding this comment.
@JorgeAndresQuintero Thanks for contributing! Please see my comments. Happy to merge once suggestions/comments are resolved. Let me know what you think :)
| @@ -178,25 +178,28 @@ func readUsernamePassword(secret *corev1.Secret) (string, string, error) { | |||
| return string(secret.Data["username"]), string(secret.Data["password"]), nil | |||
| } | |||
|
|
|||
| func managementURI(svc *corev1.Service, tlsEnabled bool, clusterDomain string, pathPrefix string) (string, error) { | |||
| func managementURI(svc *corev1.Service, useTLSForConnection bool, clusterDomain string, pathPrefix string) (string, error) { | |||
There was a problem hiding this comment.
This function currently fails with error "failed to find management from service rmq" if useTLSForConnection is false and the rabbit cluster only has TLS listener available. It should succeed and return a https scheme URI instead of failing.
There was a problem hiding this comment.
I left the logic in this function the same, but changed how useTLSForConnection is computed in line 102. That way, its value will always be false if non-TLS listeners are disabled.
|
Thanks for the review, @ChunyiLyu. I will work on it over the next couple days. |
This closes #621
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Note to contributors: remember to re-generate client set if there are any API changes
Summary Of Changes
With the env variable
CONNECT_USING_PLAIN_HTTPit is possible to configure the topology operator to communicate with the RabbitMQ Cluster using plain http, even if the cluster has TLS enabled. This is will remove the limitationdocumented in https://www.rabbitmq.com/kubernetes/operator/tls-topology-operator.html, and allow users to decide whether HTTP or HTTPS should be used.
Default behavior remains unchanged in that not setting the flag will cause the operator to keep trying to establish a HTTPS connection.