Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example manifests for queue/exchange/binding #33

Merged
merged 1 commit into from
Mar 8, 2021
Merged

Conversation

ChunyiLyu
Copy link
Contributor

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • examples for queue/exchange/binding

Additional Context

Copy link
Contributor

@coro coro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a couple typos. I'll add the user one in my PR

name: binding
spec:
vhost: "/test-vhost" # default to '/' if not provided
source: test # an exisitng exchange
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: existing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 I should publish a dictionary

rabbitmqClusterReference:
name: test
namespace: rabbitmq-system
type: quorum # withouth providing a queue type, rabbitmq creates a classic queue
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: 'without'

@ChunyiLyu ChunyiLyu merged commit 75de941 into main Mar 8, 2021
@ChunyiLyu ChunyiLyu deleted the examples branch March 8, 2021 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants