khepri_cluster: Restore the use of ra_leaderboard in members/2
#315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Why] The rework of the `khepri_cluster:members/2` to make the API close to other functions saw the drop of the call to the `ra_leaderboard`. This call was an optimization. [How] The function is simply modified to restore the call to `ra_leaderboard` if the query is a local one.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #315 +/- ##
==========================================
- Coverage 89.19% 89.11% -0.08%
==========================================
Files 22 22
Lines 3295 3299 +4
==========================================
+ Hits 2939 2940 +1
- Misses 356 359 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
deleted the
restore-leaderboard-use-in-khepri_cluster-members
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
The rework of the
khepri_cluster:members/2to make the API close to other functions saw the drop of the call to thera_leaderboard. This call was an optimization.How
The function is simply modified to restore the call to
ra_leaderboardif the query is a local one.