khepri_tx_adv: Allow calls to khepri_path in transactions
#312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Transactions might use functions like `khepri_path:combine_with_conditions/2` to modify a path from the env with extra conditions like checking the version. `khepri_path` functions are all pure - with the exception of `compile/1`, but compiling regexes within a transaction for example should be harmless - so we should allow these within transactions.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
- Coverage 89.58% 89.34% -0.24%
==========================================
Files 22 22
Lines 3263 3276 +13
==========================================
+ Hits 2923 2927 +4
- Misses 340 349 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
dumbbell
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transactions might use functions like
khepri_path:combine_with_conditions/2to modify a path from the env with extra conditions like checking the version.khepri_pathfunctions are all pure - with the exception ofcompile/1, but compiling regexes within a transaction for example should be harmless - so we should allow these within transactions.