Add global parameter mqtt-vhost mapping functions #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add generic global parameter call to allow for follow on global parameter getting functions to be implemented. - Demonstate global parameter, setting, and deleting with mqtt vhost mapping - Testing in Reactor Netty and Client specs
Correct tests in Reactor and Client spec to say testing with a blank vhost value
michaelklishin
requested changes
Jan 16, 2024
- Also rename mirror functions in Reactor Netty Client
michaelklishin
approved these changes
Jan 16, 2024
|
Let's wait for @acogoluegnes' feedback, this LGTM now. |
|
@acogoluegnes Good to close! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For this contribution, I followed the current setup of making the templated get function for global parameters that mirrors the vhost parameter setup. On top of that, also implemented the use of global parameter for port to virtual host mapping per specified by the rabbitmq mqtt plugin: https://www.rabbitmq.com/mqtt.html
Not sure if there are any other global parameters that are somewhat common that should be included.