-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create new async client based on Reactor Netty #123
Merged
Merged
Changes from 1 commit
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
fe4dc9a
Kick off Reactor Netty based client
acogoluegnes f60bbbe
Clean code of ReactorNettyClient for re-use
acogoluegnes 904f3a3
Add roadmap items to ReactorNettyClient
acogoluegnes 572c756
Don't rely on UriComponentsBuilder in ReactorNettyClient
acogoluegnes 931dd01
Use Mono<String> for Authorization header
acogoluegnes 885a409
Add URI path encoding and HTTP response wrapper
acogoluegnes 5b880c8
Implement several HTTP endpoints
acogoluegnes 35a3b29
Bump dependencies on 1.3.x
acogoluegnes 2c685c7
Merge branch '1.3.x-stable'
acogoluegnes 4706c0c
Bump Reactor release train to Bismuth-SR8
acogoluegnes 2074451
Fix compilation issue
acogoluegnes 9fa8644
Implement more endpoints in Reactor Netty client
acogoluegnes 8092e34
Add options to make Reactor Netty client configurable
acogoluegnes 1ed4fe0
Add missing tests for Reactor Netty client
acogoluegnes b3695fa
Add Javadoc to Reactor Netty client
acogoluegnes 79046be
Propagate JSON exception
acogoluegnes 89100f0
Bump Spring version to 4.3.17
acogoluegnes 5b28558
Merge branch '1.3.x-stable'
acogoluegnes a0cd820
Bump Spring to 5.0.6 and Reactor to Bismuth-SR9
acogoluegnes ef54e3e
[artifactory-release] Release version 1.3.2.RELEASE
spring-builds cd5a4cd
[artifactory-release] Next development version
spring-builds b4db01e
[artifactory-release] Release version 2.0.2.RELEASE
spring-builds 8405d17
[artifactory-release] Next development version
spring-builds 4ba9632
Merge branch '1.3.x-stable'
acogoluegnes 120b00b
Use 2.0.2.RELEASE in readme
acogoluegnes fb5558a
Kick off Reactor Netty based client
acogoluegnes 52f4a49
Clean code of ReactorNettyClient for re-use
acogoluegnes 95bea10
Add roadmap items to ReactorNettyClient
acogoluegnes cd31689
Don't rely on UriComponentsBuilder in ReactorNettyClient
acogoluegnes 99e6379
Use Mono<String> for Authorization header
acogoluegnes 411b91c
Add URI path encoding and HTTP response wrapper
acogoluegnes 49ac638
Implement several HTTP endpoints
acogoluegnes 265925f
Implement more endpoints in Reactor Netty client
acogoluegnes a1031ef
Add options to make Reactor Netty client configurable
acogoluegnes f31b4f2
Add missing tests for Reactor Netty client
acogoluegnes 0c1c63b
Add Javadoc to Reactor Netty client
acogoluegnes 304e5b1
Propagate JSON exception
acogoluegnes 1910b03
Merge branch 'reactor-netty-client' of github.com:rabbitmq/hop into r…
acogoluegnes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the
token
is that class property, thereforethis.
would help.And if it is that, it looks like
would enough and much efficient.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh! I see what you mean with
zip()
. That's becausetoken
is aMono
.Well, I think
.block()
especially for cached in-memory value isn't evil here at all.I just mean that I don't see reason in extra
zip
just for resolving credential on demand.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
token
updated tothis.token
.token
is aMono<String>
, so the point here is to get the token only when needed and potentially a value that can change between calls. The solution you suggest would work only if the token doesn't change once the instance has been created. This is actually the case by default (theAuthorization
header uses username / password digest). Does that make sense?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but you use
.cache()
there. I think this will eliminate any your attempts to change credentials at runtime.Am I missing anything else ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, you're right, the current default implementation is static and may be the one used 99% of the time. I plan to add a way to provide a custom
Mono<String> token
when creating the client, to address any case (e.g. dynamic token of some kind). This is why theaddAuthorization
is implemented this way. Hope this is clearer.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. It is now. Thank you!