Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for all dynamic shovel properties #143

Closed
mhewedy opened this issue Dec 25, 2018 · 3 comments
Closed

Support for all dynamic shovel properties #143

mhewedy opened this issue Dec 25, 2018 · 3 comments
Milestone

Comments

@mhewedy
Copy link
Contributor

mhewedy commented Dec 25, 2018

The com.rabbitmq.http.client.domain.ShovelDetails lacks most of the dynamic shovel properties. Like the ability to auto-delete the shovel using src-delete-after.

As I workaround, I created a subclass for ShovelDetails object and added the properties I needed.

It should be nice if we can configure the complete list of the properties out-of-the-box.

@michaelklishin
Copy link
Member

michaelklishin commented Dec 25, 2018

@mhewedy this is open source software. Since you've already solved the problem, consider contributing instead of asking others to do it?

@mhewedy
Copy link
Contributor Author

mhewedy commented Dec 25, 2018

I like the idea ... I will prepare the PR soon..
@michaelklishin I think I will need to add the properties into the ShovelDetails itself.. ?

@michaelklishin
Copy link
Member

Addressed by #144.

@acogoluegnes acogoluegnes added this to the 3.1.0 milestone Jan 2, 2019
acogoluegnes added a commit that referenced this issue Jan 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants