Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reject Shovel declarations with empty publish property maps #139

Closed
michaelklishin opened this issue Nov 26, 2018 · 2 comments
Closed

Reject Shovel declarations with empty publish property maps #139

michaelklishin opened this issue Nov 26, 2018 · 2 comments
Labels
effort-tiny usability
Milestone
3.0.1

Comments

@michaelklishin
Copy link
Member

Such Shovels fail to be declared (see rabbitmq/rabbitmq-shovel#46). For better compatibility with versions that won't have a more graceful handling of such property maps we should throw an exception early.
@michaelklishin
Copy link
Member Author

@acogoluegnes let me know if you disagree.

@michaelklishin
Copy link
Member Author

References #138.

michaelklishin added a commit that referenced this issue Nov 26, 2018
@michaelklishin
Throw an exception early if Shovel publish properties are blank
1b50734 
See #138, #139, rabbitmq/rabbitmq-shovel#46 for background.

Closes #139.
@michaelklishin michaelklishin mentioned this issue Nov 26, 2018
Merged
@acogoluegnes acogoluegnes added this to the 3.0.1 milestone Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort-tiny usability
Projects
None yet
Milestone
3.0.1
Development

No branches or pull requests
2 participants
@michaelklishin @acogoluegnes