Update kubectl-bats tests #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test to set debug logs was broken since the default image became 3.9.x because this commit: rabbitmq/rabbitmq-server@cdcf602 changed the debug log prefix from `debug` to `dbug`. There's a small tweak to the make target that runs the kubectl bats tests locally to include the repo's bin first in the path. This is important because the version installed by krew will take precedence. The above also allows us to simplify slightly the PR workflow file and run everything using `make`. Signed-off-by: Aitor Perez Cedres <[email protected]>
coro
approved these changes
Mar 3, 2022
ChunyiLyu
approved these changes
Mar 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
The test to set debug logs was broken since the default image became
3.9.x because this commit: rabbitmq/rabbitmq-server@cdcf602
changed the debug log prefix from
debugtodbug.There's a small tweak to the make target that runs the kubectl bats
tests locally to include the repo's bin first in the path. This is
important because the version installed by krew will take precedence.
The above also allows us to simplify slightly the PR workflow file and
run everything using
make.Local Testing