Include protocol information in Service ports #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By setting this field, we are able to take full advantage of all Istio traffic monitoring features and rich metrics, we must hint Istio what's the underlying protocol. [Source here](https://istio.io/latest/docs/ops/configuration/traffic-management/protocol-selection/). According to Kubernetes docs, protocol that are not registered in IANA registry as well-known ports, must use a suffix, like my.company.com/my-protocol. Surprisingly, STOMP does not have a well-known port assigned. https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml Signed-off-by: Aitor Perez Cedres <[email protected]>
MirahImage
approved these changes
Nov 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #878
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
appProtocolto Service Ports, to enable Istio protocol detectionAdditional Context
By setting this field, we are able to take full advantage of all Istio traffic monitoring features and rich metrics, we must hint Istio what's the underlying protocol. Source
here.
According to Kubernetes docs, protocol that are not registered in IANA registry as well-known ports, must use a suffix, like
my.company.com/my-protocol. Surprisingly, STOMP does not have a well-known port assigned.https://www.iana.org/assignments/service-names-port-numbers/service-names-port-numbers.xhtml
A system test for MQTT, STOMP and Streams may flake. That flake will be fixed by #872
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny: