Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documented examples for NetworkPolicies #859

Merged
merged 3 commits into from
Sep 29, 2021
Merged

Conversation

coro
Copy link
Contributor

@coro coro commented Sep 29, 2021

This closes #835

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

NetworkPolicies allow users to restrict the source/destination of ingress/egress traffic of their Pods. This documented example demonstrates the kinds of traffic a user may wish to restrict/allow on their cluster.

Additional Context

You can enable the network plugin on GKE for testing with:

gcloud container clusters create CLUSTER_NAME --enable-network-policy

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please see my comments for minor suggestions.

Plus, what do you think about adding a section in our rabbitmq.com doc to link to this example? I think rabbitmq.com could be a natural place for people to discover how to configure network policies.

@coro coro merged commit 4f89ad8 into main Sep 29, 2021
@coro coro deleted the network-policy-example branch September 29, 2021 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Network policy resource
3 participants