Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump timeouts for mqtt connection system tests, remove k8s 1.19 and 1.20 tests from PR workflow #775

Merged
merged 5 commits into from
Jul 21, 2021

Conversation

ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Jul 19, 2021

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Another PR to fix system tests timeout issue with PR workflow. Also removes k8s 1.19 and 1.20 from PR workflow.

The team had a discussion about github action and CI pipeline test coverage, we decided on:

  1. only test on k8s 1.21 in github action; remove k8s 1.19 and 1.20 from the system tests matrices (considering 1.21 is not available in GCP yet)
  2. test on k8s 1.19 in CI pipeline (no 1.20 coverage considering it’s unlikely to have compatibility issue that only breaks on 1.20 but not 1.19 or 1.21)
  3. PR github workflow will run system tests on 5 different rabbitmq versions: 3.8.8, latest 3.8, latest 3.9, rabbitmq-server master with OTP 23 and rabbitmq-server master with OTP 24)
  4. CI pipeline will run system tests on 5 different rabbitmq versions: 3.8.8, latest 3.8, latest 3.9, rabbitmq-server master with OTP 23 and rabbitmq-server master with OTP 24)

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@ChunyiLyu ChunyiLyu changed the title Bump timeouts for mqtt connection system tests Bump timeouts for mqtt connection system tests, remove k8s 1.19 and 1.20 tests from PR workflow Jul 21, 2021
@ChunyiLyu ChunyiLyu merged commit 825be3e into main Jul 21, 2021
@ChunyiLyu ChunyiLyu deleted the mqtt-timeouts branch July 21, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant