Remove chmod operations from init Container #739
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is no longer needed as fsGroup modifies this for us.
Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed
Summary Of Changes
fsGroup
, set in the securityContext of mounted volumes, already sets the ownership of files within the volumes, so explicitly setting them in the initContainer is unnecessary. We also no longer run as GID 999, so part of the chown operation is actively doing the wrong thing now.Additional Context
This brings the operator closer to supporting Openshift's arbitrary user flow.
Following this PR will be updates to the docs around installing on Openshift.
Local Testing
Please ensure you run the unit, integration and system tests before approving the PR.
To run the unit and integration tests:
You will need to target a k8s cluster and have the operator deployed for running the system tests.
For example, for a Kubernetes context named
dev-bunny
: