Use Prometheus TLS port if TLS is enabled #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When TLS is enabled use the prometheus-tls port in the annotation. This matches the behaviour of the Service: When TLS is enabled, port 15691 is exposed in the Service.
mkuratczyk
approved these changes
Apr 29, 2021
|
As @mkuratczyk pointed out, this change will cause a rolling restart for TLS enabled instances. Since the changes in this PR are not important and urgent enough to cause a rolling restart, we'll merge this PR once we cut a new release where the StatefulSet gets updated anyways (by some other change). |
ChunyiLyu
approved these changes
Apr 30, 2021
|
Merging this now since #675 causes a restart of the StatefulSet. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When TLS is enabled use the prometheus-tls port in the annotation.
This matches the behaviour of the Service:
When TLS is enabled, port 15691 is exposed in the Service.