Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RabbitmqClusters to categories all #660

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add RabbitmqClusters to categories all #660

merged 1 commit into from
Apr 14, 2021

Conversation

ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Apr 13, 2021

This closes #

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

Organized kubebuilder markers a bit, it looked a bit messy before.

With this change you can see rabbitmqclusters when doing kubectl get all, like

❯ k get all
NAME                                             READY   STATUS    RESTARTS   AGE
pod/rabbitmq-cluster-operator-84c7588b78-768tk   1/1     Running   0          13m
pod/sample-server-0                              1/1     Running   0          8m33s

NAME                   TYPE           CLUSTER-IP     EXTERNAL-IP      PORT(S)                          AGE
service/sample         LoadBalancer   10.7.248.214   34.105.166.183   5672:30898/TCP,15672:31213/TCP   8m34s
service/sample-nodes   ClusterIP      None           <none>           4369/TCP,25672/TCP               8m34s

NAME                                        READY   UP-TO-DATE   AVAILABLE   AGE
deployment.apps/rabbitmq-cluster-operator   1/1     1            1           13m

NAME                                                   DESIRED   CURRENT   READY   AGE
replicaset.apps/rabbitmq-cluster-operator-84c7588b78   1         1         1       13m

NAME                             READY   AGE
statefulset.apps/sample-server   1/1     8m34s

NAME                                  AGE
rabbitmqcluster.rabbitmq.com/sample   8m34s

Additional Context

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

@ChunyiLyu ChunyiLyu merged commit 1752c4a into main Apr 14, 2021
@ChunyiLyu ChunyiLyu deleted the categories-all branch April 14, 2021 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants