Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors when received PVC shrink requests #658

Merged
merged 1 commit into from
Apr 12, 2021
Merged

Errors when received PVC shrink requests #658

merged 1 commit into from
Apr 12, 2021

Conversation

ChunyiLyu
Copy link
Contributor

@ChunyiLyu ChunyiLyu commented Apr 12, 2021

This closes #653

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Summary Of Changes

  • errors, logs, publishes warning events, and set ReconcileSuccess to false when the controller received request to shrink persistence volume sizes
  • previously, when controller receives a shrink request, it does not distinguish from an expansion, and would go ahead deleting the statefulSet and then fails to shrink the PVC (PVC shrink gets rejected from k8s server)
  • integration tests to verify that storage is not updated, a warning event is published and ReconcileSuccess is set to false with specific reason and msg

Additional Context

Reported by user in issue: #653

Local Testing

Tested in integration level; all tests have passed.

controllers/reconcile_persistence.go Outdated Show resolved Hide resolved
@ChunyiLyu ChunyiLyu merged commit bf3f55a into main Apr 12, 2021
@ChunyiLyu ChunyiLyu deleted the pvc-check branch April 12, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] deleteSts and updatePVC get invoked unexpectedly when reading stale information from apiserver
3 participants