Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported tested k8s versions to match kind 0.10.0 #634

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Conversation

coro
Copy link
Contributor

@coro coro commented Mar 12, 2021

  • Removed end-of-life v1.17
  • Updated testing for v1.18 to v1.18.15
  • Updated testing for v1.19 to v1.19.7
  • Updated testing for v1.20 to v1.20.2

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

coro added 2 commits March 12, 2021 13:54
- Removed end-of-life v1.17
- Updated testing for v1.18 to v1.18.15
- Updated testing for v1.19 to v1.19.7
- Updated testing for v1.20 to v1.20.2
Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it 🛥️

@coro
Copy link
Contributor Author

coro commented Mar 22, 2021

We agreed in sync up that we would hold off on merging this until we get some clarity on users of 1.17.

cc @yaronp68

@coro coro merged commit a595f5c into main Mar 23, 2021
@coro coro deleted the deprecated-1.17 branch March 23, 2021 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants