Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump controller-runtime to v0.8.0 #565

Merged
merged 1 commit into from
Jan 19, 2021
Merged

Bump controller-runtime to v0.8.0 #565

merged 1 commit into from
Jan 19, 2021

Conversation

coro
Copy link
Contributor

@coro coro commented Jan 15, 2021

Replacement PR for #564

Controller-runtime v0.8.0 bumps k8s dependencies to v1.20 of the k8s API, which includes breaking changes to the ServiceSpec object. While we don't set these fields in our operator, the unit tests do as part of the override functionality, hence the need to both bump & fix tests.

Note to reviewers: remember to look at the commits in this PR and consider if they can be squashed

Local Testing

Please ensure you run the unit, integration and system tests before approving the PR.

To run the unit and integration tests:

$ make unit-tests integration-tests

You will need to target a k8s cluster and have the operator deployed for running the system tests.

For example, for a Kubernetes context named dev-bunny:

$ kubectx dev-bunny
$ make destroy deploy-dev
# wait for operator to be deployed
$ make system-tests

Also bumps k8s dependecies to 0.20.1 & fixes test that break due to k8s
v1.20 API changes
@ferozjilla ferozjilla self-requested a review January 18, 2021 14:37
Copy link
Contributor

@ferozjilla ferozjilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ChunyiLyu ChunyiLyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ChunyiLyu ChunyiLyu merged commit 0bba785 into main Jan 19, 2021
@ChunyiLyu ChunyiLyu deleted the 1-20-compatible-tests branch January 19, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants